Problem GUI - thread

[Gardakor]

I'm sorry for the english comments, I don't speak German
This is the code :

import javax.swing.*;
import javax.swing.event.*;
import java.awt.*;
import java.awt.event.*;

public class TestProblem implements ActionListener {
	
	public static void main(String[] args) {
		new TestProblem();
	}

	final int WAIT_TIME_IN_SECONDS = 5;
	JButton button1, button2;
	
	public TestProblem () {
		JFrame frame = new JFrame();
		JPanel window = new JPanel();
		button1 = new JButton("Test");
		button1.addActionListener(this);
		window.add(button1);
		button2 = new JButton("Click on this button, and within "+WAIT_TIME_IN_SECONDS+" seconds, 10 times on the other button");
		button2.addActionListener(this);
		window.add(button2);
		frame.setContentPane(window);
		frame.pack();
		frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
		frame.setVisible(true);
	}

	public void actionPerformed(ActionEvent e) {
		/*  
			the commands under the first if-statement show strange behaviour.
			All GUI-related commands will be only executed after this method has returned.
			Put all commands belonging to the first if-statement in an separate thread -> problem solved
		*/
		if (e.getSource() == button2) {
			// this command will be executed after this ActionEvent has been handled !
			button1.setEnabled(false);
			try {
				Thread.sleep(WAIT_TIME_IN_SECONDS * 1000);
			} catch (Exception ex) {}
			// this command will be executed after this ActionEvent has been handled !
			button1.setEnabled(true);
		}
		else if (e.getSource() == button1) {
			//JOptionPane.showMessageDialog(null, "Noooooo");
			System.out.println("Button1 pressed");
		}
	}
}

Does anybody know a better solution than starting a new thread ?
My teacher (who hasn't the time to examine this case) told me it's something about resetting the focus :bahnhof:

 

[Wildcard]

I have to admit that I don't understand your problem. What do you want to do anyway?
A better description would be helpfull.

 

[Gardakor]

I have to admit that I don't understand your problem. What do you want to do anyway?
A better description would be helpfull.

It's a simplified program, I want to do something similar, but in a large program.
In this application , I simply want that button1 is disabled for 5 seconds, after I press button2.

 

[Roar]

you have to put all code that affects the GUI into another thread which has to be invoked by SwingUtilities.invokeLater() in the actionPerformed() method.

 

[Wildcard]

Why not this way?

button1.setEnabled(true);
if (e.getSource() == button2) { 
  button1.setEnabled(false);
  Timer t = new Timer(5000,this);
   t.start();
}

 

[Gardakor]

you have to put all code that affects the GUI into another thread which has to be invoke by SwingUtilities.invokeLater() in the actionPerformed() method.

Something like this ?
But this doesn't work

		if (e.getSource() == button2) {
			SwingUtilities.invokeLater(new Thread() {
					public void run() {
						button1.setEnabled(false);
						try {
							Thread.sleep(WAIT_TIME_IN_SECONDS * 1000);
						} catch (Exception ex) {}
						// this command will be executed after this ActionEvent has been handled !
						button1.setEnabled(true);
					}
				}
			);
		}

 

[Guest]

Why not this way?

button1.setEnabled(true);
if (e.getSource() == button2) { 
  button1.setEnabled(false);
  Timer t = new Timer(5000,this);
   t.start();
}

thx for the code, but in the application I want to use it, I don't know how much time the function will consume.

 

[Wildcard]

Then you have to do it like that:

if (e.getSource() == button2) 
{ 
    button1.setEnabled(false);
    SwingUtilities.invokeLater(new Runnable() { 
        public void run() 
        { 
	                   
          try 
          { 
              Thread.sleep(WAIT_TIME_IN_SECONDS * 1000); 
               button1.setEnabled(true);
           } catch (Exception ex) {} 
          // this command will be executed after this ActionEvent has been handled ! 
		                   
        } 
    } 
);

 

[Gardakor]

Then you have to do it like that:

if (e.getSource() == button2) 
{ 
    button1.setEnabled(false);
    SwingUtilities.invokeLater(new Runnable() { 
        public void run() 
        { 
	                   
          try 
          { 
              Thread.sleep(WAIT_TIME_IN_SECONDS * 1000); 
               button1.setEnabled(true);
           } catch (Exception ex) {} 
          // this command will be executed after this ActionEvent has been handled ! 
		                   
        } 
    } 
);

This looks a lot better, but : the ActionEvents are still fired, however the button is disabled ! :meld:

 

[Wildcard]

It's clear that actionEvents are fired because button2 is still enabled. So you can either remove the ActionListener
while the Thread is active, or work with a boolean flag.

 

[Gardakor]

It's clear that actionEvents are fired because button2 is still enabled. So you can either remove the ActionListener
while the Thread is active, or work with a boolean flag.

I mean button1 ; how is it possible that clicking on button1 (while it is disabled) generates an ActionEvent after these 5 seconds ?

 

[Wildcard]

Ok, last Version :wink:

	      if (e.getSource() == button2) { 
			  button1.setEnabled(false);
		         Thread t =  new Thread(){ 
		               public void run() { 
		                   
		                  try { 
		                     sleep(WAIT_TIME_IN_SECONDS * 1000); 
							 button1.setEnabled(true);
		                  } catch (Exception ex) {System.out.println("blupp");} 
		                  // this command will be executed after this ActionEvent has been handled ! 
		                   
		               } 
		            }; 
					t.start();

 

[Gardakor]

Ok, last Version :wink:

	      if (e.getSource() == button2) { 
			  button1.setEnabled(false);
		         Thread t =  new Thread(){ 
		               public void run() { 
		                   
		                  try { 
		                     sleep(WAIT_TIME_IN_SECONDS * 1000); 
							 button1.setEnabled(true);
		                  } catch (Exception ex) {System.out.println("blupp");} 
		                  // this command will be executed after this ActionEvent has been handled ! 
		                   
		               } 
		            }; 
					t.start();

This works ! I allready implemented it like this, but I was wondering whether there was no more convenient solution.
Thx anyway :wink: