JavaFX mehrere Kreise nach Eingabeprozess ausgeben

[Conax]

Ich möchte grafisch mehrere Kreise ausgeben (am Ende soll das mal ein Binärbaum werden - aber alles Schritt für Schritt deshalb sind noch keine Linien vorhanden). Die Kreise sollen nicht irgendwo plaziert werden sondern es soll der Logik eines Binärbaums folgen. Dabei möchte ich erst einen Eingabeprozess der Werte starten und anschließend sollen die Kreise entsprechend der Werteingabe ausgegeben werden. Mein bisheriger Versuch erzeugt aber folgende Errormeldung:

Exception in Application constructor
java.lang.reflect.InvocationTargetException
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at com.sun.javafx.application.LauncherImpl.launchApplicationWithArgs(Unknown Source)
at com.sun.javafx.application.LauncherImpl.launchApplication(Unknown Source)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at sun.launcher.LauncherHelper$FXHelper.main(Unknown Source)
Caused by: java.lang.RuntimeException: Unable to construct Application instance: class Kreisversuch
at com.sun.javafx.application.LauncherImpl.launchApplication1(Unknown Source)
at com.sun.javafx.application.LauncherImpl.lambda$launchApplication$155(Unknown Source)
at java.lang.Thread.run(Unknown Source)
Caused by: java.lang.NoSuchMethodException: Kreisversuch.<init>()
at java.lang.Class.getConstructor0(Unknown Source)
at java.lang.Class.getConstructor(Unknown Source)
at com.sun.javafx.application.LauncherImpl.lambda$launchApplication1$161(Unknown Source)
at com.sun.javafx.application.PlatformImpl.lambda$runAndWait$175(Unknown Source)
at com.sun.javafx.application.PlatformImpl.lambda$null$173(Unknown Source)
at java.security.AccessController.doPrivileged(Native Method)
at com.sun.javafx.application.PlatformImpl.lambda$runLater$174(Unknown Source)
at com.sun.glass.ui.InvokeLaterDispatcher$Future.run(Unknown Source)
at com.sun.glass.ui.win.WinApplication._runLoop(Native Method)
at com.sun.glass.ui.win.WinApplication.lambda$null$148(Unknown Source)
... 1 more
Exception running application Kreisversuch

Hier der bisherige Code:

import javafx.scene.shape.*;
import javafx.application.Application;
import javafx.stage.Stage;
import javafx.event.ActionEvent;
import javafx.event.EventHandler;
import javafx.scene.input.*;
import javafx.scene.Scene;
import javafx.scene.Group;
import javafx.scene.paint.Color;
import java.util.ArrayList;
import java.util.Scanner;
import javafx.scene.layout.Pane;

public class Kreisversuch extends Application
{
    static Scanner userinput = new Scanner(System.in);
   
    static int rootvalue;
    static boolean addingnodes = true;
    static String nodevalue;
    static ArrayList<Integer> nodevaluelist = new ArrayList<Integer>();
    static ArrayList<Circle> circles = new ArrayList<Circle>();
   
    static Line line = new Line();
   
    int root;
    Kreisversuch left;
    Kreisversuch right;
   
    //this are our values to place the circles/nodes we start with root node
    int x = 400;
    int y = 10;
   
    public Kreisversuch(int root)
    {
        this.root = root;
        this.left = null;
        this.right = null;
    }
   
    public void addNewNode(int value)
    {
        //when our value is smaler as the value from our parent we have to choose the left side
        if(value <= root )
        {
            x = x - 25;
            y = y + 25;
           
            if(left == null)
            {
                left = new Kreisversuch(value);
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                left.addNewNode(value);
            }
        }
        //our value is higher compared to our parent node so we have to go to the right side
        else
        {
            x = x + 25;
            y = y + 25;
           
            if(right == null)
            {
                right = new Kreisversuch(value);
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                right.addNewNode(value);
            }
        }
    }
   
     public static void dialog()
     {
            System.out.println("Please insert value of root node");
            try
            {
             rootvalue = Integer.parseInt(userinput.next());
            }
            catch (NumberFormatException e) {}
            nodevaluelist.add(rootvalue);
           
           
             while(addingnodes == true)
             {
                    System.out.println("You can add another node value type 'no' when you are finished ");
                    nodevalue = userinput.next();
                   
                     if(nodevalue.equals("no"))
                     {
                            addingnodes = false;
                            //is used for testing if input works fine
                            System.out.println("values of my nodelist");
                            for (Integer output : nodevaluelist)
                            {
                                System.out.println(output);
                            }
                            break;
                     }
                     else
                     {
                      try
                      {
                       nodevaluelist.add(Integer.parseInt(nodevalue));
                      }
                      catch (NumberFormatException e) {}
                     }
                 }   
            }
   
    public static void main(String[] args)
    {
        launch(args);
    }
   
    public void start(Stage stage)
    {
     dialog();
       
     Kreisversuch node = new Kreisversuch(nodevaluelist.get(0));
     nodevaluelist.remove(0);
     for(int input : nodevaluelist)
     {   
       node.addNewNode(input);
     }
       
       
     //root circle
     Circle circle = new Circle(400, 10, 10, Color.BLUEVIOLET);
     circles.add(circle);
     Pane root = new Pane();
       
     Scene scene1 = new Scene(root, 800, 600);   
    
     root.getChildren().addAll(circles);
     stage.setScene(scene1);
     stage.show();
    }
   
   
}

Ich kann nicht nachvollziehen wo der Fehler ist obwohl ich nach der Fehlermeldung gegoogelt habe - Eclipse zeigt mir auch nicht an in welcher Zeile der Fehler ist. Ich habe schon ein ähnliches Programm geschrieben ohne grafische Ausgabe und dort läut alles wunderbar allerdings hätte ich das ganze natürlich schon grafisch (sieht einfach besser aus).

Danke

 

[JCODA]

Also: du ruft launch() in der main()-Methode auf. intern wird dann ein Objekt von deiner Application erstellt. Allerdings wird hierbei ein Konstruktor ohne Parameter benötigt. Du hast aber nur den Konstruktor mit dem int-Parameter. Deshalb bekommst du diese Fehlermeldung. Eine unschöne "Lösung" sähe z.B. so aus:

Spoiler: Click

import javafx.scene.shape.*;
import javafx.application.Application;
import javafx.stage.Stage;
import javafx.event.ActionEvent;
import javafx.event.EventHandler;
import javafx.scene.input.*;
import javafx.scene.Scene;
import javafx.scene.Group;
import javafx.scene.paint.Color;
import java.util.ArrayList;
import java.util.Scanner;
import javafx.scene.layout.Pane;

public class Kreisversuch extends Application
{
    static Scanner userinput = new Scanner(System.in);
  
    static int rootvalue;
    static boolean addingnodes = true;
    static String nodevalue;
    static ArrayList<Integer> nodevaluelist = new ArrayList<Integer>();
    static ArrayList<Circle> circles = new ArrayList<Circle>();
  
    static Line line = new Line();
  
    public int root;
    Kreisversuch left;
    Kreisversuch right;
  
    //this are our values to place the circles/nodes we start with root node
    int x = 400;
    int y = 10;
  
    public Kreisversuch()
    {
       
        this.left = null;
        this.right = null;
    }
  
    public void addNewNode(int value)
    {
        //when our value is smaler as the value from our parent we have to choose the left side
        if(value <= root )
        {
            x = x - 25;
            y = y + 25;
          
            if(left == null)
            {
                left = new Kreisversuch();
                left.root=value;
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                left.addNewNode(value);
            }
        }
        //our value is higher compared to our parent node so we have to go to the right side
        else
        {
            x = x + 25;
            y = y + 25;
          
            if(right == null)
            {
                right = new Kreisversuch();
                right.root = value;
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                right.addNewNode(value);
            }
        }
    }
  
     public static void dialog()
     {
            System.out.println("Please insert value of root node");
            try
            {
             rootvalue = Integer.parseInt(userinput.next());
            }
            catch (NumberFormatException e) {}
            nodevaluelist.add(rootvalue);
          
          
             while(addingnodes == true)
             {
                    System.out.println("You can add another node value type 'no' when you are finished ");
                    nodevalue = userinput.next();
                  
                     if(nodevalue.equals("no"))
                     {
                            addingnodes = false;
                            //is used for testing if input works fine
                            System.out.println("values of my nodelist");
                            for (Integer output : nodevaluelist)
                            {
                                System.out.println(output);
                            }
                            break;
                     }
                     else
                     {
                      try
                      {
                       nodevaluelist.add(Integer.parseInt(nodevalue));
                      }
                      catch (NumberFormatException e) {}
                     }
                 }  
            }
  
    public static void main(String[] args)
    {
        launch(args);
    }
  
    public void start(Stage stage)
    {
     dialog();
      
     Kreisversuch node = new Kreisversuch();
     node.root = nodevaluelist.get(0);
     nodevaluelist.remove(0);
     for(int input : nodevaluelist)
     {  
       node.addNewNode(input);
     }
      
      
     //root circle
     Circle circle = new Circle(400, 10, 10, Color.BLUEVIOLET);
     circles.add(circle);
     Pane root = new Pane();
      
     Scene scene1 = new Scene(root, 800, 600);  
   
     root.getChildren().addAll(circles);
     stage.setScene(scene1);
     stage.show();
    }
  
  
}

Du solltest dir eine einzelne Klasse bauen, die von Application erbt. Hiervon sollten am besten keine weiteren Instanzen erzeugt werden. (Du erstellst ja mehrere "Kreisversuch"e)
Damit hat natürlich wieder zutun, dass man Logik und graphische Oberfläche voneinander trennt.
Ach unschön sind die vielen static-Variablen. Das kann man bestimmt schöner lösen.

 

[Conax]

@JCODA

Danke für die Hilfe das Problem ist der Konstruktor muss in der ursprünglichen Form beibehalten werden damit das mit der Baumerzeugung richtig klappt der int wert root wird nämlich aufgrund der Rekursion jedesmal überschrieben sprich am anfang nimmt er den root wert an aber danach einen anderen (je nach hirarchiestufe). Ich habe jetzt mal den Logikpart in eine separate Klasse siehe hier:

import java.util.ArrayList;
import java.util.Scanner;

public class Node
{
    //Input over keyboard
    static Scanner userinput = new Scanner(System.in);
   
    static int rootvalue;
    static boolean addingnodes = true;
    static String nodevalue;
    static ArrayList<Integer> nodevaluelist = new ArrayList<Integer>();
    static ArrayList<Circle> circles = new ArrayList<Circle>();
   
    int root;
    Node left;
    Node right;
   
    //this are our values to place the circles/nodes we start with root node
    int x = 400;
    int y = 10;
   
    //is used for the different stages starting with higher distance
    int distance = 100;
   
    public Node(int root)
    {
        this.root = root;
        this.left = null;
        this.right = null;
    }
   
    public void addNewNode(int value)
    {
        //when our value is smaler as the value from our parent we have to choose the left side
        if(value <= root )
        {
            x = x - 25 - distance;
            y = y + 25;
            //we go one area lower and check if on the left side is a free place
            //if this is the case we are adding there our new node
            if(left == null)
            {
                left = new Node(value);
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
                x = 400;
                y = 10;
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                distance = distance / 2;
                left.addNewNode(value);
            }
        }
        //our value is higher compared to our parent node so we have to go to the right side
        else
        {
            x = x + 25 + distance;
            y = y + 25;
            //we go one area lower and check if on the right side is a free place
            //if this is the case we are adding there our new node
            if(right == null)
            {
                right = new Node(value);
                Circle circle = new Circle(x, y, 10);
                circles.add(circle);
                x = 400;
                y = 10;
            }
            //if there is already a placed node we jump in that node and do the procedure again by recursion
            else
            {
                distance = distance / 2;
                right.addNewNode(value);
            }
        }
    }
   
    public void inorder()
    { 
       if (left != null) left.inorder();
       System.out.println(root);
       if (right != null) right.inorder();
    }
   
    public void preorder()
    { 
       System.out.println(root);
       if (left != null) left.preorder();
       if (right != null) right.preorder();
    }
   
    public void postorder()
    { 
       if (left != null) left.postorder();
       if (right != null) right.postorder();
       System.out.println(root);
    }
   
    public static void dialog()
    {
        System.out.println("Please insert value of root node");
        try
        {
         rootvalue = Integer.parseInt(userinput.next());
        }
        catch (NumberFormatException e) {}
        nodevaluelist.add(rootvalue);
       
       
         while(addingnodes == true)
         {
                System.out.println("You can add another node value type 'no' when you are finished ");
                nodevalue = userinput.next();
               
                 if(nodevalue.equals("no"))
                 {
                        addingnodes = false;
                        //is used for testing if input works fine
                        System.out.println("values of my nodelist");
                        for (Integer output : nodevaluelist)
                        {
                            System.out.println(output);
                        }
                        break;
                 }
                 else
                 {
                  try
                  {
                   nodevaluelist.add(Integer.parseInt(nodevalue));
                  }
                  catch (NumberFormatException e) {}
                 }
             }   
        }
   
   
   
    public static void main(String[] args)
    {
        dialog();
        //I manualy generate the first node because it's the root node and the root node is a special node
        //because it has no parents
        Node node = new Node(nodevaluelist.get(0));
        //after I generated the root node I have to remove this node from my arraylist
        nodevaluelist.remove(0);
        for(int input : nodevaluelist)
        {   
         node.addNewNode(input);
        }
        System.out.println("output as In-order traversal");
        node.inorder();
        System.out.println("output as Pre-order traversal");
        node.preorder();
        System.out.println("output as Post-order traversal");
        node.postorder();
       
       
    }
   
}

Die Kreise (Nodes) mit ihren Koordinaten sind jetzt alle in der Arrayliste circles allerdings weis ich nicht wie ich diese jetzt grafisch ausgeben kann sprich wie ich eine Brücke schlagen kann zwischen Logik und Grafikpart.