Identifier Expected

[danielita]

Ich habe mir ein paar Dateien zum Üben heruntergeladen, sie gehören zu einem Spiel. Die untenstehende ist die Hauptdatei.

Um das Spiel zu starten, soll man ein neues Objekt der Klasse Game erzeugen und darauf die Methode play anwenden. Dies habe ich (wie ich dachte), auch in der Klasse GameTest (unten) gemacht. Leider sagt der Compiler: identifier expected...:noe:

Kann mir jemand bitte helfen? Vielen Dank

/**
 * Class Game - the main class of the "Zork" game.
 *
 * Author:  Michael Kolling
 * Version: 1.1
 * Date:    March 2000
 * 
 *  This class is the main class of the "Zork" application. Zork is a very
 *  simple, text based adventure game.  Users can walk around some scenery.
 *  That's all. It should really be extended to make it more interesting!
 * 
 *  To play this game, create an instance of this class and call the "play"
 *  routine.
 * 
 *  This main class creates and initialises all the others: it creates all
 *  rooms, creates the parser and starts the game.  It also evaluates the
 *  commands that the parser returns.
 */

class Game 
{
    private Parser parser;
    private Room currentRoom;
        

    /**
     * Create the game and initialise its internal map.
     */
    public Game() 
    {
        createRooms();
        parser = new Parser();
    }

    /**
     * Create all the rooms and link their exits together.
     */
    private void createRooms()
    {
        Room outside, lab, tavern, gblock, office;
      
        // create the rooms
        outside = new Room("outside G block on Peninsula campus");
        lab = new Room("a lecture theatre in A block");
        tavern = new Room("the Seahorse Tavern (the campus pub)");
        gblock = new Room("the G building");
        office = new Room("the computing admin office");
        
        // initialise room exits
        outside.setExits(null, lab, gblock, tavern);
        lab.setExits(null, null, null, outside);
        tavern.setExits(null, outside, null, null);
        gblock.setExits(outside, office, null, null);
        office.setExits(null, null, null, gblock);

        currentRoom = outside;  // start game outside
    }

    /**
     *  Main play routine.  Loops until end of play.
     */
    public void play() 
    {            
        printWelcome();

        // Enter the main command loop.  Here we repeatedly read commands and
        // execute them until the game is over.
                
        boolean finished = false;
        while (! finished)
        {
            Command command = parser.getCommand();
            finished = processCommand(command);
        }
        System.out.println("Thank you for playing.  Good bye.");
    }

    /**
     * Print out the opening message for the player.
     */
    private void printWelcome()
    {
        System.out.println();
        System.out.println("Welcome to Zork!");
        System.out.println("Zork is a new, incredibly boring adventure game.");
        System.out.println("Type 'help' if you need help.");
        System.out.println();
        System.out.println(currentRoom.longDescription());
    }

    /**
     * Given a command, process (that is: execute) the command.
     * If this command ends the game, true is returned, otherwise false is
     * returned.
     */
    private boolean processCommand(Command command) 
    {
        if(command.isUnknown())
        {
            System.out.println("I don't know what you mean...");
            return false;
        }

        String commandWord = command.getCommandWord();
        if (commandWord.equals("help"))
            printHelp();
        else if (commandWord.equals("go"))
            goRoom(command);
        else if (commandWord.equals("quit"))
        {
            if(command.hasSecondWord())
                System.out.println("Quit what?");
            else
                return true;  // signal that we want to quit
        }
        return false;
    }

    // implementations of user commands:

    /**
     * Print out some help information.
     * Here we print some stupid, cryptic message and a list of the 
     * command words.
     */
    private void printHelp() 
    {
        System.out.println("You are lost. You are alone. You wander");
        System.out.println("around at Monash Uni, Peninsula Campus.");
        System.out.println();
        System.out.println("Your command words are:");
        parser.showCommands();
    }

    /** 
     * Try to go to one direction. If there is an exit, enter the new
     * room, otherwise print an error message.
     */
    private void goRoom(Command command) 
    {
        if(!command.hasSecondWord())
        {
            // if there is no second word, we don't know where to go...
            System.out.println("Go where?");
            return;
        }

        String direction = command.getSecondWord();

        // Try to leave current room.
        Room nextRoom = currentRoom.nextRoom(direction);

        if (nextRoom == null)
            System.out.println("There is no door!");
        else 
        {
            currentRoom = nextRoom;
            System.out.println(currentRoom.longDescription());
        }
    
}

}

class GameTest{
	public static void main(){
	Game g = new Game();
	g.play();}
	}

 

[Leroy42]

Leider sagt der Compiler: identifier expected...

In welcher Zeile taucht dieser Fehler denn auf?

 

[danielita]

Sorry

In der Zeile 164, da, wo g.play(); steht.

 

[ARadauer]

poste mal die fehlenden Klassen...

 

[SlaterB]

das ist nicht nachvollziehbar, steht noch was bei den ...?

bei mir kompiliert mit entsprechenden Hilfsklassen am Ende

public class Test
{
    public static void main(String[] args)
    {
       
    }
}

class Game
{
    private Parser parser;
    private Room currentRoom;


    /**
     * Create the game and initialise its internal map.
     */
    public Game()
    {
        createRooms();
        parser = new Parser();
    }

    /**
     * Create all the rooms and link their exits together.
     */
    private void createRooms()
    {
        Room outside, lab, tavern, gblock, office;

        // create the rooms
        outside = new Room("outside G block on Peninsula campus");
        lab = new Room("a lecture theatre in A block");
        tavern = new Room("the Seahorse Tavern (the campus pub)");
        gblock = new Room("the G building");
        office = new Room("the computing admin office");

        // initialise room exits
        outside.setExits(null, lab, gblock, tavern);
        lab.setExits(null, null, null, outside);
        tavern.setExits(null, outside, null, null);
        gblock.setExits(outside, office, null, null);
        office.setExits(null, null, null, gblock);

        currentRoom = outside; // start game outside
    }

    /**
     * Main play routine. Loops until end of play.
     */
    public void play()
    {
        printWelcome();

        // Enter the main command loop. Here we repeatedly read commands and
        // execute them until the game is over.

        boolean finished = false;
        while (!finished)
        {
            Command command = parser.getCommand();
            finished = processCommand(command);
        }
        System.out.println("Thank you for playing.  Good bye.");
    }

    /**
     * Print out the opening message for the player.
     */
    private void printWelcome()
    {
        System.out.println();
        System.out.println("Welcome to Zork!");
        System.out.println("Zork is a new, incredibly boring adventure game.");
        System.out.println("Type 'help' if you need help.");
        System.out.println();
        System.out.println(currentRoom.longDescription());
    }

    /**
     * Given a command, process (that is: execute) the command. If this command ends the
     * game, true is returned, otherwise false is returned.
     */
    private boolean processCommand(Command command)
    {
        if (command.isUnknown())
        {
            System.out.println("I don't know what you mean...");
            return false;
        }

        String commandWord = command.getCommandWord();
        if (commandWord.equals("help"))
            printHelp();
        else if (commandWord.equals("go"))
            goRoom(command);
        else if (commandWord.equals("quit"))
        {
            if (command.hasSecondWord())
                System.out.println("Quit what?");
            else
                return true; // signal that we want to quit
        }
        return false;
    }

    // implementations of user commands:

    /**
     * Print out some help information. Here we print some stupid, cryptic message and a
     * list of the command words.
     */
    private void printHelp()
    {
        System.out.println("You are lost. You are alone. You wander");
        System.out.println("around at Monash Uni, Peninsula Campus.");
        System.out.println();
        System.out.println("Your command words are:");
        parser.showCommands();
    }

    /**
     * Try to go to one direction. If there is an exit, enter the new room, otherwise
     * print an error message.
     */
    private void goRoom(Command command)
    {
        if (!command.hasSecondWord())
        {
            // if there is no second word, we don't know where to go...
            System.out.println("Go where?");
            return;
        }

        String direction = command.getSecondWord();

        // Try to leave current room.
        Room nextRoom = currentRoom.nextRoom(direction);

        if (nextRoom == null)
            System.out.println("There is no door!");
        else
        {
            currentRoom = nextRoom;
            System.out.println(currentRoom.longDescription());
        }

    }

}


class GameTest
{
    public static void main()
    {
        Game g = new Game();
        g.play();
    }
}


class Parser
{

    public Command getCommand()
    {
        return null;
    }

    public void showCommands()
    {
    }
}


class Room
{

    public Room(String string)
    {
    }

    public void setExits(Object object, Room lab, Room gblock, Room tavern)
    {
    }

    public char[] longDescription()
    {
        return null;
    }

    public Room nextRoom(String direction)
    {
        return null;
    }
}


class Command
{

    public boolean isUnknown()
    {
        return false;
    }

    public String getSecondWord()
    {
        return null;
    }

    public boolean hasSecondWord()
    {
        return false;
    }

    public String getCommandWord()
    {
        return null;
    }
}

 

[Leroy42]

In der Zeile 164, da, wo g.play(); steht.

Zeile 164 ist eine Leerzeile.

Meinst du

    public static void main(){
        Game g = new Game();
        g.play();}
    }

Hier kann ich mir nicht vorstellen, daß der Compiler identifier expected
meldet, da g ja eine Zeile zuvor definiert wird. :bahnhof:

Aber dir Methode müßte sowieso heißen:

    public static void main(String[] args){...}

 

[danielita]

Jetzt ging das Kompilieren auf einmal, allerdings bekomme ich jetzt einen nosuchmethod-Error wegen der Mainmethode. Habe die Methode allerdings abgeändert, so wie du gesagt hast, Leroy.???:L

class GameTest{
	public static void main(String[] args){
	Game g = new Game();
	g.play();}
	}

 

[SlaterB]

main-Methoden machen nur in public-Klassen sind, die dann auch genauso wie die Datei heißen

andererseits kannst du es ruhig nochmal probieren, wenn alles erst verzögert funktioniert

 

[danielita]

Vielen Dank! Jetzt gehts ich habe eine separate Datei mit dem Namen GameTest angelegt und die Klasse als public gekennzeichnet.