generischer binärbaum

[Guest]

hallo, also ich hab folgendes code

public class BinaryTreeNode implements BinaryNode<T> {

	private Object data;
	/** @return the data entry hold by the tree node */
	public Object getData() { 
		return data;	
	}

	private Integer key;
	/** @return the key entry associated width the tree node */
	public Integer getKey() {
		return key; 
	}
	
	private BinaryTreeNode parent = null;
	/** @return the parent of the tree node. null if the node is the root of the tree*/
	public BinaryTreeNode getParent() {
		return parent; 
	}
	/** sets the parent of the tree node.*/
	public void setParent(BinaryTreeNode newParent) {
		this.parent = newParent; 
	}
	
	
	private BinaryTreeNode left = null;
	/** @return the left child node of the tree node. null if there is no left child*/
	public BinaryTreeNode getLeft() { 
		return left; 
	}
	/** sets the left Child of the tree node.*/
	public void setLeft(BinaryTreeNode newLeft) { 
		this.left = newLeft; 
	}

	private BinaryTreeNode right = null;
	/** @return the right child node of the tree node. null if there is no right child*/
	public BinaryTreeNode getRight() { 
		return right; 
	}
	/** sets the right Child of the tree node.*/
	public void setRight(BinaryTreeNode newRight) { 
		this.right = newRight; 
	}
	
	
	
	
	/** Basic Node Constructor.
	 *  @param newKey the key who is used to find the position of the node in the tree.
	 *  @param the data stored in the tree node.
	 */
	public BinaryTreeNode(Integer newKey, Object newData) 
	{
		this.key = newKey;
		this.data = newData;
	}		
	
	
	
	@Override
	public String toString(){
		return this.key.toString() + ":" + this.data.toString();
	}
	

}

ich sollte es in eine generische klasse umwandeln u. nach der umwandlung sollen Integer u. Data nichr mehr in BinaryTreeNode auftauchen. Alle Referenzen auf andere Knoten sollen dann Referenzen auf den generischen Knotentyp sein.
danke im voraus für Tipps

 

[SlaterB]

suche nach der Buchstabenkombination I und n und t und e und g und e und r,
lösche sie und schreibe dafür den Buchstaben T hin,

und bisschen mehr ist noch zu tun,
aber bevor du so eine Aufgabe machst, weißt du ja sicher ganz genau was Generics ist
und wie man eine generische Klasse korrekt schreibt, oder?

 

[Gast]

public class BinaryTreeNode implements BinaryNode<T> {

private <T> data;
/** @return the data entry hold by the tree node */
public <T> getData() {
return data;
}

private <T> key;
/** @return the key entry associated width the tree node */
public <T> getKey() {
return key;
}

private BinaryTreeNode parent = null;
/** @return the parent of the tree node. null if the node is the root of the tree*/
public BinaryTreeNode getParent() {
return parent;
}
/** sets the parent of the tree node.*/
public void setParent(BinaryTreeNode newParent) {
this.parent = newParent;
}


private BinaryTreeNode left = null;
/** @return the left child node of the tree node. null if there is no left child*/
public BinaryTreeNode getLeft() {
return left;
}
/** sets the left Child of the tree node.*/
public void setLeft(BinaryTreeNode newLeft) {
this.left = newLeft;
}

private BinaryTreeNode right = null;
/** @return the right child node of the tree node. null if there is no right child*/
public BinaryTreeNode getRight() {
return right;
}
/** sets the right Child of the tree node.*/
public void setRight(BinaryTreeNode newRight) {
this.right = newRight;
}




/** Basic Node Constructor.
* @param newKey the key who is used to find the position of the node in the tree.
* @param the data stored in the tree node.
*/
public BinaryTreeNode( <T> newKey, <T> newData)
{
this.key = newKey;
this.data = newData;
}



@Override
public <T> toString(){
return this.key.toString() + ":" + this.data.toString();
}


}

was generics ist weiss ich, die sache dass man integer mit <T> ersetzt, war auch klar nur hab ich mich gefragt ob man das gleiche mit Data machen soll/kann?

 

[SlaterB]

> die sache dass man integer mit <T> ersetzt, war auch klar

hmm, aber das stimmt ja gerade nicht, nur T hinschreiben, nicht <T> (an den meisten Stellen, dort wo vorher Integer stand),
und weiter:
BinaryTreeNode durch BinaryTreeNode<T> ersetzen

> hab ich mich gefragt ob man das gleiche mit Data machen soll/kann

zu soll kann ich nix sagen, kann ist denkbar, U wäre der nächste Buchstabe

 

[Guest]

also soll ich so was haben

public class BinaryTreeNode<T> implements BinaryNode<T> {

	private  T data;
	/** @return the data entry hold by the tree node */
	public  T getData() { 
		return data;	
	}

	private U key;
	/** @return the key entry associated width the tree node */
	public  U getKey() {
		return key; 
	}
	
	private BinaryTreeNode <T> parent = null;
	/** @return the parent of the tree node. null if the node is the root of the tree*/
	public BinaryTreeNode <T> getParent() {
		return parent; 
	}
	/** sets the parent of the tree node.*/
	public void setParent(BinaryTreeNode <T> newParent) {
		this.parent = newParent; 
	}
	
	
	private BinaryTreeNode <T> left = null;
	/** @return the left child node of the tree node. null if there is no left child*/
	public BinaryTreeNode <T> getLeft() { 
		return left; 
	}
	/** sets the left Child of the tree node.*/
	public void setLeft(BinaryTreeNode <T> newLeft) { 
		this.left = newLeft; 
	}

	private BinaryTreeNode <T> right = null;
	/** @return the right child node of the tree node. null if there is no right child*/
	public BinaryTreeNode <T> getRight() { 
		return right; 
	}
	/** sets the right Child of the tree node.*/
	public void setRight(BinaryTreeNode <T> newRight) { 
		this.right = newRight; 
	}
	
	
	
	
	/** Basic Node Constructor.
	 *  @param newKey the key who is used to find the position of the node in the tree.
	 *  @param the data stored in the tree node.
	 */
	public BinaryTreeNode <T>( T newKey,  U newData) 
	{
		this.key = newKey;
		this.data = newData;
	}		
	
	
	
	@Override
	public  W toString(){
		return this.key.toString() + ":" + this.data.toString();
	}
	

}

 

[Guest]

tippfehler...

public class BinaryTreeNode<T> implements BinaryNode<T> {

	private  U data;
	/** @return the data entry hold by the tree node */
	public  U getData() { 
		return data;	
	}

	private T key;
	/** @return the key entry associated width the tree node */
	public  T getKey() {
		return key; 
	}
	
	private BinaryTreeNode <T> parent = null;
	/** @return the parent of the tree node. null if the node is the root of the tree*/
	public BinaryTreeNode <T> getParent() {
		return parent; 
	}
	/** sets the parent of the tree node.*/
	public void setParent(BinaryTreeNode <T> newParent) {
		this.parent = newParent; 
	}
	
	
	private BinaryTreeNode <T> left = null;
	/** @return the left child node of the tree node. null if there is no left child*/
	public BinaryTreeNode <T> getLeft() { 
		return left; 
	}
	/** sets the left Child of the tree node.*/
	public void setLeft(BinaryTreeNode <T> newLeft) { 
		this.left = newLeft; 
	}

	private BinaryTreeNode <T> right = null;
	/** @return the right child node of the tree node. null if there is no right child*/
	public BinaryTreeNode <T> getRight() { 
		return right; 
	}
	/** sets the right Child of the tree node.*/
	public void setRight(BinaryTreeNode <T> newRight) { 
		this.right = newRight; 
	}
	
	
	
	
	/** Basic Node Constructor.
	 *  @param newKey the key who is used to find the position of the node in the tree.
	 *  @param the data stored in the tree node.
	 */
	public BinaryTreeNode <T>( T newKey,  U newData) 
	{
		this.key = newKey;
		this.data = newData;
	}		
	
	
	
	@Override
	public  W toString(){
		return this.key.toString() + ":" + this.data.toString();
	}
	

}

 

[SlaterB]

> T newKey, U newData
+
> public U getKey()

bisschen aufpassen schadet nicht..,
ansonsten zwar mit Fehlern aber die Richtung ist gut

> public W toString(){

na nun ist es aber übertrieben , das muss String bleiben

 

[Guest]

gibt es noch fehler drin?

public class BinaryTreeNode<T> implements BinaryNode<T> {

	private  U data;
	/** @return the data entry hold by the tree node */
	public  U getData() { 
		return data;	
	}

	private T key;
	/** @return the key entry associated width the tree node */
	public  T getKey() {
		return key; 
	}
	
	private BinaryTreeNode <T> parent = null;
	/** @return the parent of the tree node. null if the node is the root of the tree*/
	public BinaryTreeNode <T> getParent() {
		return parent; 
	}
	/** sets the parent of the tree node.*/
	public void setParent(BinaryTreeNode <T> newParent) {
		this.parent = newParent; 
	}
	
	
	private BinaryTreeNode <T> left = null;
	/** @return the left child node of the tree node. null if there is no left child*/
	public BinaryTreeNode <T> getLeft() { 
		return left; 
	}
	/** sets the left Child of the tree node.*/
	public void setLeft(BinaryTreeNode <T> newLeft) { 
		this.left = newLeft; 
	}

	private BinaryTreeNode <T> right = null;
	/** @return the right child node of the tree node. null if there is no right child*/
	public BinaryTreeNode <T> getRight() { 
		return right; 
	}
	/** sets the right Child of the tree node.*/
	public void setRight(BinaryTreeNode <T> newRight) { 
		this.right = newRight; 
	}
	
	
	
	
	/** Basic Node Constructor.
	 *  @param newKey the key who is used to find the position of the node in the tree.
	 *  @param the data stored in the tree node.
	 */
	public BinaryTreeNode <T>( <T> newKey,  <U> newData) 
	{
		this.key = newKey;
		this.data = newData;
	}		
	
	
	
	@Override
	public  String toString(){
		return this.key.toString() + ":" + this.data.toString();
	}
	

}

mfg

 

[SlaterB]

das sagt dir dein Compiler

 

[Benzin]

public class BinaryTreeNode<T,U> implements BinaryNode<T,U>{
...
}

ich glaub' nur so kann eine generische Klasse mehrere Typvariablen enthalten.