Du verwendest einen veralteten Browser. Es ist möglich, dass diese oder andere Websites nicht korrekt angezeigt werden. Du solltest ein Upgrade durchführen oder ein alternativer Browser verwenden.
Hallo,
ich brauche Eure hilfe mit dem Action Handling. Mein Projekt ist um einiges groesser, nachdem ich gesehn hab dass man vieles auch einfacher machen kann (sollte !), wollte ich das Projekt umstrukturieren. Nun bekam ich neue Probleme. Ich habe nun versucht ein kl. Bsp. zu schreiben (s.u.) und wenn mir jemand dabei weiterhelfen kann die fixme-Stellen zu loesen, waeren einige meiner Fragen auch schon geklaert. Danke schon mal !!!
Das Ding unten sollte soweit funktionieren (Grafik) bis eben auf die letzte Klasse. Die Stellen, bei denen ich kA hab wie ich das machen soll, hab ich mit "fixme" bezeichnet. Es wuerde mir schon helfen, nur einige der fixme Stellen exemplarisch zu loesen oder mir an Hand von etwas Code zu erklaeren, wie man das richtig angehen wuerde.
Genauso freu ich mich immer auch ueber konstruktive Kritik und Anregungen zu meinem Design der Klassen (ich hoffe keiner von Euch bekommt Augenkrebs wenn er den Code unten sieht :autsch: ).
Code:
package action01;
import java.awt.GridLayout;
import javax.swing.JFrame;
import javax.swing.JPanel;
// Main Panel - resp. for jframe
public class MainPanel extends JPanel{
// var
private static Panel1 p1;
private static Panel2 p2;
private static int iNumber;
// ctor
public MainPanel(){
super(new GridLayout(1,0));
iNumber = 0;
p1 = new Panel1();
p2 = new Panel2();
}
// func
public static void createAndShowGUI(){
JFrame.setDefaultLookAndFeelDecorated(true);
JFrame frame = new JFrame(String.valueOf(iNumber));
// fixme - how to add iNumber to the MyActionListener, so that it can be changed ?
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setResizable(false);
frame.setLocation(300,100);
MainPanel ga = new MainPanel();
ga.add(p1.drawP1());
ga.add(p2.drawP2());
ga.setOpaque(true);
frame.setContentPane(ga);
frame.pack();
frame.setVisible(true);
}
///////////////////////////////////////////////////////////
// main
public static void main(String[]args){
javax.swing.SwingUtilities.invokeLater(new Runnable() {
public void run() {
createAndShowGUI();
}
});
}
}
package action01;
import java.awt.GridLayout;
import javax.swing.ButtonGroup;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
// radio button panel: one, two
public class Panel1 extends JPanel{
// var
JRadioButton jbOne, jbTwo, jbThree;
// ctor
public Panel1(){
super(new GridLayout(1,0));
}
// func
public Panel1 drawP1(){
jbOne = new JRadioButton("one");
jbTwo = new JRadioButton("two");
// fixme - how to add them to the MyActionListener ?
ButtonGroup group = new ButtonGroup();
group.add(jbOne);
group.add(jbTwo);
jbOne.setSelected(true);
this.add(jbOne);
this.add(jbTwo);
return this;
}
}
package action01;
import java.awt.GridLayout;
import javax.swing.JButton;
import javax.swing.JPanel;
// jbuttons: ok, exit
public class Panel2 extends JPanel{
// var
JButton butOk, butExit;
// ctor
public Panel2(){
super(new GridLayout(2,0));
}
//func
public Panel2 drawP2(){
butOk = new JButton("OK");
butExit = new JButton("Exit");
// fixme - how to add them to the MyActionListener ?
this.add(butOk);
this.add(butExit);
return this;
}
}
package action01;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
// ... now real fun starts:
class MyActionListener implements ActionListener{
// var
// ctor
MyActionListener(){}
// func
public void actionPerformed(ActionEvent ae) {
if((ae.getSource()).equals(Panel-1-Obj.jbOne)){
// fixme - how to ask for an attribute of an other object?
MainPanel-Obj.iNumber = 1;
// fixme - might a get/setter pair for iNumber in MainPanel be better?
// fixme - how to set title of MainPanels obj to "String.valueOf(iNumber)"?
}else if((ae.getSource()).equals(Panel-1-Obj.jbTwo)){
// fixme - how to ask for an attribute of an other object?
MainPanel-Obj.iNumber = 2;
// fixme - might a get/setter pair for iNumber in MainPanel be better?
// fixme - how to set title of MainPanels obj to "String.valueOf(iNumber)"?
}else if((ae.getSource()).equals(Panel-2-Obj.Ok)){
// fixme - how to ask for an attribute of an other object?
System.out.println("Hello Work!");
}else if((ae.getSource()).equals(Panel-2-Obj.Exit)){
// fixme - how to ask for an attribute of an other object?
System.exit(1);
}
}
}
Finde deine Struktur etwas seltsam!
Warum erbt deine Hauptklasse von JPanel, erzeugt in einer STATISCHEN Methode einen JFrame um sich dann dort selbst zu adden?
Warum nicht gleich von JFrame erben, alles nötige im Konstruktor erledigen, und dann den Inhalt setzten.
Warum gehst du in main den Weg über invokeLater???
Ich bin ein gegner von implements ActionListener und eigenen ActionListener Klassen.
Ich finde es sehr viel übersichtlicher wenn jede Komponente eine eigene annonymen innere ActionListenerKlasse bekommt, und dieser auf entsprechende Methoden 'umverteilt', da man sich dieses lästige e.getSource().equals zeug spart.
Soweit mal meine Meinung dazu
OK,
dann halt hier hin verschoben (?!) aber nun kommt einiges an "Codegeschnipsel", ich hab nun vier versch. Designs fuer das Event Handling versucht und wollte mal Eure Meinung dazu hoeren. Also was fuer welchen Zweck sinnvoller ist, was man wo benutzt, ob sie ueberhaupt richtig implementiert sind, ob es bessere Moeglichkeiten gibt (wie gesagt, das eigentliche Programm ist etwas groesser) und natuerlich worauf man achten sollte. Wann also welches Design.
Danke schon mal an Wildcard, tja ich fand dieses Design mal wo in nem Beispiel, da ich das auch nich ganz verstanden hab, hab ich draus mal ein Beispiel gemacht, was ich hiermit hier poste Vielleicht weiss ja jemand auch dazu was zu sagen. (Somit ist zwar schon mein Hauptproblem das "Design des ActionHandlers" aber auch irgendwie das allg. Design...)
Es folgen nun 4 Varianten - hier Version 1:
Code:
package localActionListener;
import java.awt.GridLayout;
import java.util.Observable;
import java.util.Observer;
import javax.swing.JFrame;
import javax.swing.JPanel;
// seperate method actionPerformed, panels implement action listener
public class MainPanel extends JPanel{
private static Panel1 p1;
private static Panel2 p2;
private static JFrame frame;
private static ModelMVC model = null;
public MainPanel(final ModelMVC newModel){
super(new GridLayout(1,0));
model = newModel;
p1 = new Panel1(model);
p2 = new Panel2();
}
// func
public static void createAndShowGUI(){
JFrame.setDefaultLookAndFeelDecorated(true);
frame = new JFrame(String.valueOf("0"));
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setResizable(false);
frame.setLocation(300,100);
MainPanel ga = new MainPanel(new ModelMVC());
ga.add(p1.drawP1());
ga.add(p2.drawP2());
model.addObserver(new Observer(){
public void update(Observable o, Object arg){
ModelMVC theModel = (ModelMVC)o;
frame.setTitle(theModel.getVal());
}
});
ga.setOpaque(true);
frame.setContentPane(ga);
frame.pack();
frame.setVisible(true);
}
///////////////////////////////////////////////////////////
// main
public static void main(String[]args){
try{
javax.swing.SwingUtilities.invokeLater(new Runnable() {
public void run() {
createAndShowGUI();
}
});
}catch(Exception e){
e.printStackTrace();
}
}
}
///
package localActionListener;
import java.util.Observable;
public class ModelMVC extends Observable{
private String szVal = "";
public void setVal(String sz){
this.szVal = sz;
this.setChanged();
this.notifyObservers( szVal);
}
public String getVal(){
return this.szVal;
}
}
///
package localActionListener;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.ButtonGroup;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
// radio button panel: one, two
public class Panel1 extends JPanel implements ActionListener{
// var
private JRadioButton jbOne, jbTwo;
private ModelMVC model = null;
// ctor
public Panel1(final ModelMVC newModel){
super(new GridLayout(1,0));
this.model = newModel;
}
// func
public Panel1 drawP1(){
jbOne = new JRadioButton("one");
jbTwo = new JRadioButton("two");
jbOne.addActionListener(this); //
jbTwo.addActionListener(this); //
ButtonGroup group = new ButtonGroup();
group.add(jbOne);
group.add(jbTwo);
jbOne.setSelected(true);
this.add(jbOne);
this.add(jbTwo);
return this;
}
// Action Performed as separated method
public void actionPerformed(ActionEvent e) {
if((e.getSource()).equals(jbOne)){
model.setVal("1");
}else if((e.getSource()).equals(jbTwo)){
model.setVal("2");
}
}
}
///
package localActionListener;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
// jbuttons: ok, exit
public class Panel2 extends JPanel implements ActionListener{
JButton butOk, butExit;
public Panel2(){
super(new GridLayout(2,0));
}
//func
public Panel2 drawP2(){
butOk = new JButton("Ok");
butOk.addActionListener(this); //
butExit = new JButton("Exit");
butExit.addActionListener(this); //
this.add(butOk);
this.add(butExit);
return this;
}
public void actionPerformed(ActionEvent e) {
if((e.getSource()).equals(butOk)){
System.out.println("whole panel implements action listener interface");
}else if((e.getSource()).equals(butExit)){
System.exit(1);
}
}
}
Hier Version 2:
Code:
package globalActionListener;
import java.awt.GridLayout;
import java.awt.event.ActionListener;
import java.util.Observable;
import java.util.Observer;
import javax.swing.JFrame;
import javax.swing.JPanel;
// separate class action listener for bigger projects ??
public class MainPanel extends JPanel{
private static Panel1 p1;
private static Panel2 p2;
private static JFrame frame;
private static ModelMVC model = null;
public MainPanel(){
super(new GridLayout(1,0));
p1 = new Panel1();
p2 = new Panel2();
}
// func
public static void createAndShowGUI(ActionListener al, final ModelMVC brandNewModel){
model = brandNewModel;
JFrame.setDefaultLookAndFeelDecorated(true);
frame = new JFrame(String.valueOf("0"));
// setTitle() Problem...
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setResizable(false);
frame.setLocation(300,100);
MainPanel ga = new MainPanel();
ga.add(p1.drawP1(al));
ga.add(p2.drawP2(al));
model.addObserver(new Observer(){
public void update(Observable o, Object arg){
ModelMVC theModel = (ModelMVC)o;
frame.setTitle(theModel.getVal());
}
});
ga.setOpaque(true);
frame.setContentPane(ga);
frame.pack();
frame.setVisible(true);
}
////////////////////////////////////////////////////////////////////////
public static void main(String[]args){
final ModelMVC newModel = new ModelMVC();
final MyActionListener cmd = new MyActionListener(newModel);
javax.swing.SwingUtilities.invokeLater( new Runnable(){
public void run(){
MainPanel.createAndShowGUI(cmd, newModel);
}
});
}
}
///
package globalActionListener;
import java.util.Observable;
public class ModelMVC extends Observable{
private String szVal = "";
public void setVal(String sz){
this.szVal = sz;
this.setChanged();
this.notifyObservers( szVal);
}
public String getVal(){
return this.szVal;
}
}
///
package globalActionListener;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
class MyActionListener implements ActionListener{
private ModelMVC model = null;
MyActionListener(final ModelMVC newModel){
this.model = newModel;
}
// func
public void actionPerformed(ActionEvent ae) {
if((ae.getSource()).equals(Panel1.jbOne)){
model.setVal("1");
}else if((ae.getSource()).equals(Panel1.jbTwo)){
model.setVal("2");
}else if((ae.getSource()).equals(Panel2.butOk)){
System.out.println("seperated action listener class");
}else if((ae.getSource()).equals(Panel2.butExit)){
System.exit(1);
}
}
}
///
package globalActionListener;
import java.awt.GridLayout;
import java.awt.event.ActionListener;
import javax.swing.ButtonGroup;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
// radio button panel: one, two
public class Panel1 extends JPanel{
public static JRadioButton jbOne;
public static JRadioButton jbTwo;
public Panel1(){
super(new GridLayout(1,0));
}
// func
public Panel1 drawP1(ActionListener al){
jbOne = new JRadioButton("one");
jbTwo = new JRadioButton("two");
jbOne.addActionListener(al); //
jbTwo.addActionListener(al); //
ButtonGroup group = new ButtonGroup();
group.add(jbOne);
group.add(jbTwo);
jbOne.setSelected(true);
this.add(jbOne);
this.add(jbTwo);
return this;
}
}
///
package globalActionListener;
import java.awt.GridLayout;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
// jbuttons: ok, exit
public class Panel2 extends JPanel{
public static JButton butOk;
public static JButton butExit;
public Panel2(){
super(new GridLayout(2,0));
}
//func
public Panel2 drawP2(ActionListener al){
butOk = new JButton("OK");
butOk.addActionListener(al);
butExit = new JButton("Exit");
butExit.addActionListener(al);
this.add(butOk);
this.add(butExit);
return this;
}
}
Hier Version 3:
Code:
package innerClasses;
// Version with Inner Classes:
import java.awt.GridLayout;
import java.util.Observable;
import java.util.Observer;
import javax.swing.JFrame;
import javax.swing.JPanel;
public class MainPanel extends JPanel{
private static Panel1 p1;
private static Panel2 p2;
private static JFrame frame;
public MainPanel(){
super(new GridLayout(1,0));
p1 = new Panel1();
p2 = new Panel2();
}
public static void createAndShowGUI(){
JFrame.setDefaultLookAndFeelDecorated(true);
frame = new JFrame(String.valueOf("0"));
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setResizable(false);
frame.setLocation(300,100);
MainPanel ga = new MainPanel();
final ModelMVC acmeModel = new ModelMVC();
ga.add(p1.drawP1(acmeModel));
ga.add(p2.drawP2(acmeModel));
acmeModel.addObserver(new Observer(){
public void update(Observable o, Object arg){
ModelMVC theModel = (ModelMVC)o;
frame.setTitle(theModel.getVal());
}
});
ga.setOpaque(true);
frame.setContentPane(ga);
frame.pack();
frame.setVisible(true);
}
///////////////////////////////////////////////////////////
public static void main(String[]args){
javax.swing.SwingUtilities.invokeLater(new Runnable() {
public void run() {
createAndShowGUI();
}
});
}
}
///
package innerClasses;
import java.util.Observable;
public class ModelMVC extends Observable{
private String szVal = "";
public void setVal(String sz){
this.szVal = sz;
this.setChanged();
this.notifyObservers( szVal);
}
public String getVal(){
return this.szVal;
}
}
///
package innerClasses;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.ButtonGroup;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
// radio button panel: one, two
public class Panel1 extends JPanel{
public static JRadioButton jbOne;
public static JRadioButton jbTwo;
public Panel1(){
super(new GridLayout(1,0));
}
// func
public Panel1 drawP1(ModelMVC newModel){
jbOne = new JRadioButton("one");
jbTwo = new JRadioButton("two");
MyActionListener al = new MyActionListener(newModel);
jbOne.addActionListener(al);
jbTwo.addActionListener(al);
ButtonGroup group = new ButtonGroup();
group.add(jbOne);
group.add(jbTwo);
jbOne.setSelected(true);
this.add(jbOne);
this.add(jbTwo);
return this;
}
class MyActionListener implements ActionListener{
private ModelMVC model = null;
MyActionListener(final ModelMVC brandNewModel){
this.model = brandNewModel;
}
public void actionPerformed(ActionEvent e) {
if((e.getSource()).equals(jbOne)){
model.setVal("1");
}else if((e.getSource()).equals(jbTwo)){
model.setVal("2");
}
}
}
}
///
package innerClasses;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
// jbuttons: ok, exit
public class Panel2 extends JPanel{
public static JButton butOk;
public static JButton butExit;
public Panel2(){
super(new GridLayout(2,0));
}
//func
public Panel2 drawP2(ModelMVC newModel){
butOk = new JButton("OK");
butExit = new JButton("Exit");
MyActionListener al = new MyActionListener(newModel);
butOk.addActionListener(al);
butExit.addActionListener(al);
this.add(butOk);
this.add(butExit);
return this;
}
class MyActionListener implements ActionListener{
private ModelMVC model = null;
public MyActionListener(final ModelMVC brandNewModel){
this.model = brandNewModel;
}
public void actionPerformed(ActionEvent e) {
if((e.getSource()).equals(butOk)){
System.out.println("Inner Class Version");
}else if((e.getSource()).equals(butExit)){
System.exit(1);
}
}
}
}
...und endlich Version 4 - puh:
Code:
package anonymousClasses;
import java.awt.GridLayout;
import java.util.Observable;
import java.util.Observer;
import javax.swing.JFrame;
import javax.swing.JPanel;
// Version: anonymous class
public class MainPanel extends JPanel{
private static JFrame frame;
private static Panel1 p1;
private static Panel2 p2;
private static ModelMVC model = null;
public MainPanel(final ModelMVC brandNewModel){
super(new GridLayout(1,0));
model = brandNewModel;
p1 = new Panel1(model);
p2 = new Panel2();
}
// func
public static void createAndShowGUI(final ModelMVC newModel){
JFrame.setDefaultLookAndFeelDecorated(true);
frame = new JFrame(String.valueOf("0"));
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
frame.setResizable(false);
frame.setLocation(300,100);
MainPanel ga = new MainPanel(newModel);
ga.add(p1.drawP1());
ga.add(p2.drawP2());
model.addObserver(new Observer(){
public void update(Observable o, Object arg){
ModelMVC theModel = (ModelMVC)o;
frame.setTitle(theModel.getVal());
}
});
ga.setOpaque(true);
frame.setContentPane(ga);
frame.pack();
frame.setVisible(true);
}
///////////////////////////////////////////////////////////
public static void main(String[]args){
javax.swing.SwingUtilities.invokeLater(new Runnable() {
public void run() {
createAndShowGUI(new ModelMVC());
}
});
}
}
///
package anonymousClasses;
import java.util.Observable;
public class ModelMVC extends Observable{
private String szVal = "";
public void setVal(String sz){
this.szVal = sz;
this.setChanged();
this.notifyObservers( szVal);
}
public String getVal(){
return this.szVal;
}
}
///
package anonymousClasses;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.ButtonGroup;
import javax.swing.JPanel;
import javax.swing.JRadioButton;
// radio button panel: one, two
public class Panel1 extends JPanel{
JRadioButton jbOne, jbTwo, jbThree;
ModelMVC model = null;
public Panel1(final ModelMVC newModel){
super(new GridLayout(1,0));
model = newModel;
}
// func
public Panel1 drawP1(){
jbOne = new JRadioButton("one");
jbTwo = new JRadioButton("two");
ButtonGroup group = new ButtonGroup();
group.add(jbOne);
group.add(jbTwo);
jbOne.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e){
if((e.getSource()).equals(jbOne)){
model.setVal("1");
}
}
});
jbTwo.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e){
if((e.getSource()).equals(jbTwo)){
model.setVal("2");
}
}
});
jbOne.setSelected(true);
this.add(jbOne);
this.add(jbTwo);
return this;
}
}
///
package anonymousClasses;
import java.awt.GridLayout;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;
import javax.swing.JButton;
import javax.swing.JPanel;
// jbuttons: ok, exit
public class Panel2 extends JPanel{
JButton butOk, butExit;
public Panel2(){
super(new GridLayout(2,0));
}
//func
public Panel2 drawP2(){
butOk = new JButton("OK");
butExit = new JButton("Exit");
butOk.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e){
if((e.getSource()).equals(butOk)){
System.out.println("version of anonymous classes");
}
}
});
butExit.addActionListener(new ActionListener(){
public void actionPerformed(ActionEvent e){
if((e.getSource()).equals(butExit)){
System.exit(1);
}
}
});
this.add(butOk);
this.add(butExit);
return this;
}
}
Ich bedanke mich zumindest schon mal bei denen, die bis hier her ueberhaupt gelesen haben
